Use macos-26 runners and test on Intel/ARM#2348
Draft
sirosen wants to merge 2 commits intojazzband:mainfrom
Draft
Use macos-26 runners and test on Intel/ARM#2348sirosen wants to merge 2 commits intojazzband:mainfrom
sirosen wants to merge 2 commits intojazzband:mainfrom
Conversation
In the matrix config, separate the notions of "os.name" (the nice name shown in the CI GUI) from "os.runs_on" (the value used for selecting the runner). They are still aligned after this change, but can now be manipulated independently.
Pin the macOS CI runners specifically to `macos-26` and `macos-26-intel`.
Member
Author
|
This appears to be working as desired, but I find the results in CI wall clock time a bit concerning. I'm also worried that by increasing the number of builds by so much, we're increasing the changes of flaky failures. We want to solve those anyway, but "want to fix" != "have fixed". Many projects consider it sufficient to test their max and min Python versions on Windows and macOS. I think I would be comfortable doing that at least for these new Intel-mac builds, to keep CI times more under control. It would require refactoring the job config a bit, but I think it's necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open as a draft because I think this needs to be linked to relevant issues. It also needs to actually run in CI to confirm it works as desired.
Contributor checklist
Included tests for the changes.changelog.d/(seechangelog.d/README.mdfor instructions) or the PR text says "no changelog needed".
Maintainer checklist
bot:chronographer:skiplabel.(following Semantic Versioning).