added feature to send email once the user is blocked based on username#242
Open
saurav-codes wants to merge 1 commit intojazzband:masterfrom
Open
added feature to send email once the user is blocked based on username#242saurav-codes wants to merge 1 commit intojazzband:masterfrom
saurav-codes wants to merge 1 commit intojazzband:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #242 +/- ##
==========================================
- Coverage 92.58% 91.03% -1.55%
==========================================
Files 13 13
Lines 418 435 +17
==========================================
+ Hits 387 396 +9
- Misses 31 39 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
@saurav-codes it looks like some of the tests failed, it might require a change to the tox settings. maybe something changed recently. |
Collaborator
|
@saurav-codes The change looks reasonable; if you can get the tests to pass and update the documentation, it should be good to merge. Thanks |
Contributor
|
Just out of curiosity, wouldn’t it be slightly better to implement this based on django signals ? This would allow to plug-in other notification sources than email. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation Details
The implementation checks for a new setting,
DEFENDER_EMAIL_USER_ON_ACCOUNT_LOCKED, to determine if an email should be sent when an account is locked. by default it's False.An email template
defender/lockout_email.htmlis provided, which can be overridden by settingDEFENDER_LOCKOUT_EMAIL_TEMPLATE_PATHin the project's settings. The email is sent using Django's built-insend_mailfunction, assuming that the email backend configured for the project.