Skip to content

feat: enhance prediction handling by validating output channels and a…#188

Merged
rhoadesScholar merged 33 commits intomainfrom
multi_channel_writing
Feb 20, 2026
Merged

feat: enhance prediction handling by validating output channels and a…#188
rhoadesScholar merged 33 commits intomainfrom
multi_channel_writing

Conversation

@rhoadesScholar
Copy link
Member

…djusting target array shapes

Copilot AI review requested due to automatic review settings February 19, 2026 15:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the prediction pipeline to better handle models whose outputs don’t map 1:1 to the configured class list, by inferring/validating output channel counts and reshaping target array specs accordingly.

Changes:

  • Adds a preflight forward pass to infer the model’s output channel count and (optionally) adjust target_arrays[*]["shape"].
  • Updates per-batch prediction handling to support “multiple channels per class” by splitting the output tensor into per-class tensors.
  • Adds (intended) validation/erroring for output-channel/class-count mismatches during prediction.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI commented Feb 19, 2026

@rhoadesScholar I've opened a new pull request, #189, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI commented Feb 19, 2026

@rhoadesScholar I've opened a new pull request, #191, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link
Contributor

Copilot AI commented Feb 19, 2026

@rhoadesScholar I've opened a new pull request, #192, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link
Contributor

Copilot AI commented Feb 19, 2026

@rhoadesScholar I've opened a new pull request, #193, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link
Contributor

Copilot AI commented Feb 19, 2026

@rhoadesScholar I've opened a new pull request, #194, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member Author

@rhoadesScholar rhoadesScholar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gtg

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI commented Feb 20, 2026

@rhoadesScholar I've opened a new pull request, #196, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI and others added 2 commits February 20, 2026 20:41
Fix num_channels_per_class=1 behavior in structure_model_output
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rhoadesScholar rhoadesScholar merged commit 3a75efa into main Feb 20, 2026
11 checks passed
@rhoadesScholar rhoadesScholar deleted the multi_channel_writing branch February 20, 2026 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants