Skip to content

[jaeger-operator]upgrade to using helm3 crd procedure since crd-install hook is no lon… #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vincenthcui wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[jaeger-operator]upgrade to using helm3 crd procedure since crd-install hook is no lon… #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/jaeger-operator/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v1
description: jaeger-operator Helm chart for Kubernetes
name: jaeger-operator
version: 2.17.0
version: 2.18.0
appVersion: 1.19.0
home: https://www.jaegertracing.io/
icon: https://www.jaegertracing.io/img/jaeger-icon-reverse-color.svg
Expand Down
1 change: 0 additions & 1 deletion charts/jaeger-operator/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ The following table lists the configurable parameters of the jaeger-operator cha
| `image.pullPolicy` | Controller container image pull policy | `IfNotPresent` |
| `jaeger.create` | Jaeger instance will be created | `false` |
| `jaeger.spec` | Jaeger instance specification | `{}` |
| `crd.install` | CustomResourceDefinition will be installed | `true` |
| `rbac.create` | All required roles and rolebindings will be created | `true` |
| `serviceAccount.create` | Service account to use | `true` |
| `rbac.pspEnabled` | Pod security policy for pod will be created and included in rbac role | `false` |
Expand Down
3 changes: 0 additions & 3 deletions charts/jaeger-operator/crds/crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@ apiVersion: apiextensions.k8s.io/v1beta1
kind: CustomResourceDefinition
metadata:
name: jaegers.jaegertracing.io
annotations:
"helm.sh/hook": crd-install
Copy link

@kd7lxl kd7lxl Jan 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

"helm.sh/hook-delete-policy": "before-hook-creation"
labels:
app: jaeger-operator
spec:
Expand Down
6 changes: 0 additions & 6 deletions charts/jaeger-operator/templates/crds.yaml
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions charts/jaeger-operator/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@ image:
pullPolicy: IfNotPresent
imagePullSecrets: []

crd:
install: true

jaeger:
# Specifies whether Jaeger instance should be created
create: false
Expand Down