re-order exports object in package.json per spec#8
Open
jeffhuys wants to merge 2 commits intoivesia:masterfrom
Open
re-order exports object in package.json per spec#8jeffhuys wants to merge 2 commits intoivesia:masterfrom
jeffhuys wants to merge 2 commits intoivesia:masterfrom
Conversation
|
Can this please be merged in, this fixes an issue we are also seeing |
|
Any update on getting this merged? We are stuck on 1.0.1 until it is. |
kester36
approved these changes
May 20, 2024
leob
added a commit
to leob/vite-plugin-rewrite-all
that referenced
this pull request
Jun 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent PR #2 by @CommanderStorm broke our build (and @ericleponner 's - see #7).
Looking at PR #2 and comparing it to the spec (https://nodejs.org/api/packages.html#conditional-exports) shows me that the ordering of the object is not correct.
Specifically this part:
This PR aims to fix this. Confirmed to fix on our end.