Adding support for non-overlapping tiles#81
Open
piyushrpt wants to merge 3 commits intoisce-framework:mainfrom
Open
Adding support for non-overlapping tiles#81piyushrpt wants to merge 3 commits intoisce-framework:mainfrom
piyushrpt wants to merge 3 commits intoisce-framework:mainfrom
Conversation
mattcalef
approved these changes
May 15, 2025
mattcalef
left a comment
There was a problem hiding this comment.
These changes look reasonable to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing the specific use case of island groups where we end up unrealistic looking Delaunay triangulations.
The easiest way to override the tile generation is to drop in a custom tile
tiles.jsonfile with each island is in its own tile.The merge process just reassembles the unwrapped tiles and does not put attempt to resolve cycles between the islands.
Down stream impacts: