Update Elasticsearch handling of schools list#786
Draft
axlewin wants to merge 11 commits into
Draft
Conversation
This is no longer used anywhere now that the school list reader uses a BooleanInstruction
The new schoolId fieldname contains a capital letter, so capitalisation matters where it didn't before. The raw fields suffix also breaks things for some reason, and since this is an exact match query anyway we don't need to explicitly disable things like stemming, so it should be safe to remove the suffix.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #786 +/- ##
==========================================
+ Coverage 40.28% 40.32% +0.03%
==========================================
Files 546 546
Lines 23800 23778 -22
Branches 2906 2901 -5
==========================================
Hits 9588 9588
+ Misses 13311 13289 -22
Partials 901 901 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| if (matchingSchoolList.size() > 1) { | ||
| log.error("Error while looking up school up by id! More than one match for '{}' results: {}", schoolURN, matchingSchoolList); | ||
| log.error("Error while looking up school up by id! More than one match for '{}' results: {}", schoolId, matchingSchoolList); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BooleanInstruction-based query