Skip to content

Migrate to DPDK25.11 LTS #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
guvenc merged 7 commits into from
Dec 18, 2025
Merged

Migrate to DPDK25.11 LTS #750

guvenc merged 7 commits into from
Dec 18, 2025

Conversation

@byteocean
Copy link
Contributor

@byteocean byteocean commented Dec 10, 2025

Prepared to migrate to DPDK25.11 LTS

@byteocean byteocean mentioned this pull request Dec 10, 2025
Closed
@PlagueCZ
Copy link
Contributor

PlagueCZ commented Dec 10, 2025

Should we not use the new DPDK macros for packed structures instead of using gcc-based ones? Not sure how we discussed it last time.

Where did the MTU patch reversal go? It was needed to not break stuff (force MTU to 1500 on PF0/1) on the host.

@byteocean
Copy link
Contributor Author

byteocean commented Dec 10, 2025 •
edited
Loading

you meant __rte_packed_begin and __rte_packed_end? @PlagueCZ

@PlagueCZ
Copy link
Contributor

PlagueCZ commented Dec 10, 2025

you meant __rte_packed_begin and __rte_packed_end? @PlagueCZ

Yes. I do not remember the result of our discussion last time, but I think we should use them, then if we want to go back to DPDK24, we can simply define them ourselves as (none) and _rte_packed to simulate them, but the code can use them easily.

But maybe we found a reason why use the GCC ones, though I do not remember.

@byteocean byteocean marked this pull request as ready for review December 16, 2025 08:59
@byteocean byteocean requested a review from a team as a code owner December 16, 2025 08:59
@byteocean byteocean self-assigned this Dec 16, 2025
@byteocean byteocean moved this to In Progress in Roadmap Dec 16, 2025
@byteocean byteocean added this to the H2/2025 milestone Dec 16, 2025
@guvenc
Copy link
Collaborator

guvenc commented Dec 16, 2025

@byteocean
Looks like this patch is also addressing #727 ?

@guvenc guvenc linked an issue Dec 16, 2025 that may be closed by this pull request
Telemetry add_array/dict_u64 functions will be removed from DPDK #727
Closed
@byteocean
Copy link
Contributor Author

byteocean commented Dec 16, 2025

@byteocean Looks like this patch is also addressing #727 ?

yes, 'accidentally'.

PlagueCZ
PlagueCZ reviewed Dec 16, 2025
View reviewed changes
Copy link
Contributor

@PlagueCZ PlagueCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in OSC lab environment, seems to be working. Quick tests did not show a problem with performance.
No deep testing has been done, though.

@guvenc guvenc linked an issue Dec 17, 2025 that may be closed by this pull request
Prepare to migrate to DPDK25 #732
Closed
guvenc
guvenc approved these changes Dec 18, 2025
View reviewed changes
Copy link
Collaborator

@guvenc guvenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guvenc guvenc merged commit 1ef2800 into main Dec 18, 2025
6 checks passed
@guvenc guvenc deleted the enh/dpdk25lts branch December 18, 2025 07:51
@github-project-automation github-project-automation bot moved this from In Progress to Done in Roadmap Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PlagueCZ PlagueCZ PlagueCZ left review comments

@guvenc guvenc guvenc approved these changes

Assignees

@byteocean byteocean

Labels

area/networking ok-to-image size/L

Projects

Roadmap
Status: Done

Milestone

H2/2025

Development

Successfully merging this pull request may close these issues.

Prepare to migrate to DPDK25 Telemetry add_array/dict_u64 functions will be removed from DPDK

5 participants

@byteocean @PlagueCZ @guvenc @hardikdr