feat(vue-router): upgrade to vue-router 5#31117
Open
Conversation
…istory, and view stacks
…o feat/vue-router-upgrade
…o feat/vue-router-upgrade
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
package: core
ShaneK
changed the title
ShaneK
force-pushed
the
feat/vue-router-upgrade
branch
from
561f950 to
3f69ec4
Compare
|
Nice, Will it work with |
thetaPC
reviewed
May 7, 2026
| shell: bash | ||
| working-directory: ./packages/vue/test/build/${{ inputs.app }} | ||
| - name: 📦 Install Playwright Browsers | ||
| run: npx playwright install chromium |
Contributor
There was a problem hiding this comment.
Why Chromium? The Angular tests don't pass in a browser.
thetaPC
reviewed
May 7, 2026
| cd "$SCRIPT_DIR" | ||
|
|
||
| # --------------------------------------------------------------------------- | ||
| # Test runner for the Vue Router upgrade work (FW-7121). |
Contributor
There was a problem hiding this comment.
Should this line be in here? Seems more like a comment for yourself?
thetaPC
reviewed
May 7, 2026
| "@typescript-eslint/eslint-plugin": "^5.48.2", | ||
| "@typescript-eslint/parser": "^5.48.2", | ||
| "eslint": "^7.32.0", | ||
| "jest": "^28.1.1", |
Contributor
There was a problem hiding this comment.
Out of curiosity, should we be aiming to remove Jest from the repo entirely?
thetaPC
reviewed
May 7, 2026
| "vue-router": "^5.0.6" | ||
| }, | ||
| "devDependencies": { | ||
| "@playwright/test": "^1.48.0", |
Contributor
There was a problem hiding this comment.
Not sure if it's possible but maybe we should make sure that renovate upgrades this as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
@ionic/vue-routerand@ionic/vuebuild against vue-router 4What is the new behavior?
Bumps
vue-routerto^5.0.6andvueto^3.5.0(vue-router 5 raises its peer to^3.5.0). We also added Playwright tests for Vue router that are in full parity with the previous Jest and removed the Jest tests and replaced them with Playwright.This PR also makes the current Vue test app, which is also used for the Vue Router automated tests, get rebuilt with the current PR version for testing in the Vercel preview links.
Does this introduce a breaking change?
Consumer apps that pin
vue-routerthemselves need to upgrade to^5.0.0, and apps that explicitly pinvueneed to bump to^3.5.0Other information
CI changes: CI no longer runs
npm run test.spec(the script and Jest devDeps are gone), and now runs playwright testsPreview (Vue + Vue Router test app, demos both packages from this PR):
https://ionic-framework-git-feat-vue-router-upgrade-ionic1.vercel.app/vue/