feat(item-sliding): added specific animations for ionic#31103
feat(item-sliding): added specific animations for ionic#31103os-davidlourenco wants to merge 9 commits intonextfrom
Conversation
os-davidlourenco
added
package: core
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
removed
package: angular
os-davidlourenco
force-pushed
the
ROU-12715
branch
from
6dc87ba to
a247ac5
Compare
os-davidlourenco
force-pushed
the
ROU-12715
branch
from
c2f1465 to
7468b4c
Compare
thetaPC
left a comment
thetaPC
left a comment
There was a problem hiding this comment.
Update the branch to be up to sync with next. We had to make changes to the item sliding tests that were causing tests that were failing while you were out. I would recommend reviewing the fix in case your tests need to be updated.
brandyscarney
left a comment
brandyscarney
left a comment
There was a problem hiding this comment.
Left a comment on the ticket!
thetaPC
left a comment
thetaPC
left a comment
There was a problem hiding this comment.
I only reviewed the test. I'll leave the rest to the current reviewers.
| const peek = config.direction === 'rtl' ? 120 : -120; | ||
| await dragElementBy(item, page, peek); |
There was a problem hiding this comment.
Would this check be beneficial to add to ios and md?
| expect(openAmount).toBe(0); | ||
| }); | ||
|
|
||
| test('should NOT trigger full swipe animation for non-expandable options', async ({ page }) => { |
There was a problem hiding this comment.
This doesn't seem to be any different from the test on ios and md. Let's just merge them together.
There was a problem hiding this comment.
The tests are very similar but not the same. On the Ionic theme, we will not have any event independently of whether the kind of swipe is expandable is false, but on md and iOS is still possible to have an event:
- onEndNative() correctly blocks the full-swipe animation when hasExpandable is false.
- But it still emits ionSwipe based on SwipeEnd/SwipeStart state flags.
- Those flags are set by distance in setOpenAmount() for native, without checking hasExpandable.
4 participants
Issue number: resolves internal
What is the current behavior?
The
item-slidinghas the same animations for md, iOS and IonicWhat is the new behavior?
New animations were added for the Ionic theme, including:
item-slidingitem-slidingNew conditions were also included to ensure a smoother experience:
item-slidingby exceeding velocityDoes this introduce a breaking change?
Other information