Fix VTK actor leak due to incorrect cleanup guard in e-field visualization#1112
Open
suhr25 wants to merge 1 commit intoinvesalius:masterfrom
Open
Fix VTK actor leak due to incorrect cleanup guard in e-field visualization#1112suhr25 wants to merge 1 commit intoinvesalius:masterfrom
suhr25 wants to merge 1 commit intoinvesalius:masterfrom
Conversation
Replace broken AND-gated cleanup guards with independent per-actor is-not-None checks in MaxEfieldActor, CoGEfieldActor, and InitEfield. Add missing = None resets after RemoveActor so VTK objects are released promptly and the renderer does not accumulate orphaned actors across efield reloads and navigation updates. Signed-off-by: suhr25 <suhridmarwah07@gmail.com>
Contributor
Author
|
Hi @paulojamorim, |
Contributor
Author
|
Just following up on this PR when you have a moment. |
Contributor
Author
|
Hi @sotodela @paulojamorim, |
Contributor
Author
|
Hi @sotodela @paulojamorim, |
Contributor
Author
|
Hi @sotodela @paulojamorim, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a renderer cleanup issue in
viewer_volume.pyaffectingMaxEfieldActor(),CoGEfieldActor(), andInitEfield().Previously, actors were not always removed due to a coupled
andcondition, which could skip cleanup if one actor wasNone. This could leave valid actors in the renderer without Python references, causing a VTK-side memory/rendering leak.Fix
= NoneafterRemoveActor()to release references.edge_actor.Before
After
Verification
Repeated
InitEfield()calls keep actor count stable (self.ren.GetActors().GetNumberOfItems()), with no memory growth or visual changes.