Skip to content

Feature/uv project mgmt#93

Open
sherlockhommel wants to merge 6 commits into
developfrom
feature/uv-project-mgmt
Open

Feature/uv project mgmt#93
sherlockhommel wants to merge 6 commits into
developfrom
feature/uv-project-mgmt

Conversation

@sherlockhommel
Copy link
Copy Markdown
Collaborator

Hi all,

in this PR, I did exclusively work on the "outer form" of pya:

  1. I changed the project management to use uv uniformly. This entails managing most of the tools from a pyproject.toml and enforces the creation of a uv.lock file that guarantees a synced setup for all devs (except from portaudio installation - maybe we can find a solution for that as well).
  2. I added pre-commit hooks (mostly ruff) and went through a lot of small issues with ruffs standards. This is making up the bulk of the changes
  3. The sphinx setup for the documentation did not work anymore (some version conflicts in newer package versions) and I changed that from autoapi to autodoc and auto summary
  4. I also updated the tox setup and GitHub workflows to work fine with uv. The main pya-ci.yaml workflow should now execute matrix testing for Windows, MacOS and Ubuntu

In general, these changes only affect an active development setup. End-Users still use the normal installation from pypi (via pip, conda, ...).

Since these are mostly maintenance-related changes, I do not think you need to review these in detail - consider invitations for review more as an FYI :)

Also, this branch will probably have a few more changes before merging, definitely:

  • add all contributors in documentation and pyproject.toml
  • add description of developer setup, running tests, building documentation etc with uv in /dev

Best Greetings and thanks for having a view,

Fabian

Copy link
Copy Markdown
Member

@thomas-hermann thomas-hermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skimmed over the changes: wow, it's a lot. As you say too much to review in detail.
My conclusion is: looks good, please go ahead .

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage is 71.902%feature/uv-project-mgmt into develop. No base build found for develop.

@wiccy46
Copy link
Copy Markdown
Collaborator

wiccy46 commented May 12, 2026

Hi. Thanks for the effort. But I must say, this is impossible to review a 8k+ line. I am sorry, but I can't do it. Not sure if many can.

I would suggest two paths forward:

  1. Just merge it without my involvement.
  2. Break it into smaller chunks and iterative PRs. PR should be as small as possible to complete per feature.

I am fine with either option.

@thomas-hermann
Copy link
Copy Markdown
Member

Thanks, Jiajun. Then let's proceed! As this PR is about project management it won't touch active code apart from formatting, so merging should be OK. Next step then will be to bring in the changes from the feature-agen branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants