Feature/uv project mgmt#93
Open
sherlockhommel wants to merge 6 commits into
Open
Conversation
Member
thomas-hermann
left a comment
There was a problem hiding this comment.
I skimmed over the changes: wow, it's a lot. As you say too much to review in detail.
My conclusion is: looks good, please go ahead .
Collaborator
|
Hi. Thanks for the effort. But I must say, this is impossible to review a 8k+ line. I am sorry, but I can't do it. Not sure if many can. I would suggest two paths forward:
I am fine with either option. |
Member
|
Thanks, Jiajun. Then let's proceed! As this PR is about project management it won't touch active code apart from formatting, so merging should be OK. Next step then will be to bring in the changes from the feature-agen branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all,
in this PR, I did exclusively work on the "outer form" of
pya:pyproject.tomland enforces the creation of auv.lockfile that guarantees a synced setup for all devs (except from portaudio installation - maybe we can find a solution for that as well).autoapitoautodocandauto summarypya-ci.yamlworkflow should now execute matrix testing for Windows, MacOS and UbuntuIn general, these changes only affect an active development setup. End-Users still use the normal installation from pypi (via
pip,conda, ...).Since these are mostly maintenance-related changes, I do not think you need to review these in detail - consider invitations for review more as an FYI :)
Also, this branch will probably have a few more changes before merging, definitely:
pyproject.tomluvin/devBest Greetings and thanks for having a view,
Fabian