refactor init of compressor #1339
Open
+383
−216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: n1ck-guo <[email protected]>
n1ck-guo
requested review from
Copilot,
wenhuach21 and
xin3he
and removed request for
Copilot
xin3he
reviewed
Jan 26, 2026
Signed-off-by: n1ck-guo <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the initialization logic of the compressor by introducing a _post_init method to handle operations that require delayed execution. The changes move various setup operations from __init__ to _post_init to prevent bugs caused by incorrect call ordering, particularly for operations that depend on the model being fully loaded or other initialization steps being complete.
Changes:
- Introduced a
_post_initmethod to handle delayed initialization logic including scheme parsing, device setup, seed setting, and torch compile adjustments - Moved output directory path calculation logic from
__main__.pyinto thequantize_and_savemethod - Simplified
__init__by deferring complex initialization steps that have dependencies on other attributes
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| auto_round/compressors/base.py | Refactored initialization by moving delayed-execution logic (scheme parsing, device setup, seed setting, etc.) from __init__ to new _post_init method; added path calculation to quantize_and_save and save_quantized |
| auto_round/main.py | Simplified by removing output directory path calculation logic that was moved into the compressor class |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Signed-off-by: n1ck-guo <[email protected]>
Signed-off-by: n1ck-guo <[email protected]>
…-round into hengguo/refactor_init
Signed-off-by: n1ck-guo <[email protected]>
wenhuach21
reviewed
Jan 27, 2026
| ValueError: If an unsupported format is specified. | ||
| """ | ||
| # post init | ||
| self._post_init() |
Contributor
There was a problem hiding this comment.
How can developers know which initialization code belongs in post_init?
Signed-off-by: n1ck-guo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move some functions that require delayed execution to
post_initto avoid bugs caused by incorrect call order.Type of Change
Related Issues
Fixes or relates to #
Checklist Before Submitting