chore: updated instrumentations with safety check on promises #2283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhilash-sivan
force-pushed
the
chore-safety-promise-check
branch
2 times, most recently
from
d73be58 to
73c0a64
Compare
abhilash-sivan
force-pushed
the
chore-safety-promise-check
branch
from
73c0a64 to
d29bfaa
Compare
abhilash-sivan
commented
Jan 19, 2026
| span.transmitManual(); | ||
| }); | ||
| } else { | ||
| span.d = Date.now() - span.ts; |
Contributor
Author
There was a problem hiding this comment.
else case added for case:
If this is not a promise, then end the span gracefully
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs https://jsw.ibm.com/browse/INSTA-70534