Phi indicator#222
Conversation
|
Since I am not familiar with the phi indicator, could @light-weaver or @giomara-larraga have a look at the code? Assuming you are more familiar with the indicator. If not, let me know as well. |
|
@light-weaver will be checking this. |
|
@light-weaver could you take a look at the Phi indicator? On the last meeting you mention I should remove the classes. Do you want me to keep the PhiDecision functionality or it's not necessary (it was in desdeo1). I will have time to work on this until tomorrow evening |
|
@pStefanec. Treat PHI and PHIdecision as two different indicators. Have separate methods/functions to calculate them. Make sure that the function signatures are similar to the other methods in the file. Make sure that the assumptions stated at the top of the file are followed as well. |
Migrating PHI indicator from desdeo-tools.
PHI calculation maybe works (at least it does not fail and provides seemingly reasonable values).
PHIDecision fails because the arrays in the assessment calculation have different shapes... Did it work in the desdeo-tools?
Also why in get_weights the main_rp param is not even used?