Fix race condition and add validation in user special membership request patch method#668
Merged
danieleguido merged 3 commits intofeature/review-patchfrom Feb 15, 2026
Merged
Conversation
…ateLastModified, use logger Co-authored-by: danieleguido <1181642+danieleguido@users.noreply.github.com>
Co-authored-by: danieleguido <1181642+danieleguido@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add patch method to update membership request status
Fix race condition and add validation in user special membership request patch method
Feb 13, 2026
danieleguido
approved these changes
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review feedback from PR #667. The patch method had a race condition with async Celery calls, lacked input validation, and didn't maintain audit timestamps.
Changes
Await Celery client call: Fixed race condition where test assertions could execute before task queueing completed. Changed from
.catch()pattern to properawaitwith try-catch.Update dateLastModified: Automatically set on patch operations to maintain audit trail consistency with create operations.
Validate status field: Reject invalid status values with BadRequest. Only
pending,approved,rejectedare permitted.Use Winston logger: Replaced
console.errorwithlogger.errorfor consistent log management.Added test coverage for status validation and dateLastModified behavior.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.