Add env variable to distinguish development mode, add dev env yaml#356
Draft
k-dominik wants to merge 3 commits intoilastik:mainfrom
Draft
Add env variable to distinguish development mode, add dev env yaml#356k-dominik wants to merge 3 commits intoilastik:mainfrom
k-dominik wants to merge 3 commits intoilastik:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #356 +/- ##
=======================================
Coverage 41.07% 41.07%
=======================================
Files 109 109
Lines 11545 11554 +9
=======================================
+ Hits 4742 4746 +4
- Misses 6803 6808 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
We used to do special releases of ilastik for stable versions where exceptions that occur during fetch_layer_tile would be ignored. These exceptions seem to be triggered by temporary inconsistencies in the graph and are so far transient in nature - no need to inform users about this. But in development mode we do want to see them in order to further identify and reduce such cases. Environment setup now also sets the environment variable `ILASTIK_DEVELOPMENT_ENV`, which is used to determine if such exceptions should be only logged, or raised.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used to do special releases of ilastik for stable versions where exceptions that occur during fetch_layer_tile would be ignored. These exceptions seem to be triggered by temporary inconsistencies in the graph and are so far transient in nature - no need to inform users about this. But in development mode we do want to see them in order to further identify and reduce such cases.
Environment setup now also sets the environment variable
ILASTIK_DEVELOPMENT_ENV, which is used to determine if such exceptions should be only logged, or raised.