Skip to content

Update Node.js version and enhance workflow configuration #101

Open
blytkerchan wants to merge 3 commits intoilammy:masterfrom
blytkerchan:dev
Open

Update Node.js version and enhance workflow configuration #101
blytkerchan wants to merge 3 commits intoilammy:masterfrom
blytkerchan:dev

Conversation

@blytkerchan
Copy link
Copy Markdown

  • Update Node.js version to 24 in action.yml
  • Add Visual Studio 2025 version mapping to VsYearVersion
  • Add 'dev' and 'main' branches to push trigger in workflow
  • Fix typos in action.yml and lib.js comments
  • Add dependabot configuration for npm and GitHub Actions updates
  • Update actions/checkout version to v6 in main workflow
  • Update GitHub Actions workflow to support Visual Studio 2025 and 2026
  • Add configurable support for ARM32 architecture (to disable it where not supported)
  • Fix compilation commands for ARM architecture in main workflow (don't always expect exe)
  • Remove Windows 2019 runner from workflow matrix -- no longer supported

* Update Node.js version to 24 in action.yml
* Add Visual Studio 2025 version mapping to VsYearVersion
* Add 'dev' and 'main' branches to push trigger in workflow
* Fix typos in action.yml and lib.js comments
* Add dependabot configuration for npm and GitHub Actions updates
* Update actions/checkout version to v6 in main workflow
* Update GitHub Actions workflow to support Visual Studio 2025 and 2026
* Add configurable support for ARM32 architecture (to disable it where not supported)
* Fix compilation commands for ARM architecture in main workflow (don't always expect exe)
* Remove Windows 2019 runner from workflow matrix -- no longer supported
- Added @vercel/ncc as a devDependency in package.json
- Updated the build script in package.json to use ncc for building the project
- Updated package-lock.json to reflect the addition of @vercel/ncc
@sergio-nsk
Copy link
Copy Markdown

Update Node.js version to 24 in action.yml

This is done here #94

@mk-pmb
Copy link
Copy Markdown

mk-pmb commented Mar 31, 2026

Thank you for this PR, which made this fix very easy:

     steps:
       - name: 'Install Visual Studio Build Tools'
-        uses: ilammy/msvc-dev-cmd@v1
+        uses: ilammy/msvc-dev-cmd@138b1c783b65ec697d8342918306b7b2db4e88f1

@madmajestro
Copy link
Copy Markdown

@ilammy

Many projects use your GitHub action. If you no longer have the time or interest to maintain this project (which is perfectly fine), you could make another developer a collaborator who could continue the maintenance or help out for a certain period. The project would continue, and several people wouldn't have to create a fork. Imho that would be better for everyone (including you) than letting the project die. What do you think?

I regularly contribute code to https://github.com/krakjoe/apcu, and this action is used there. Therefore, I would be happy if this project continues to work and I didn't have to worry about finding another solution...

@pzhlkj6612
Copy link
Copy Markdown
Contributor

FWIW, I just found that someone has made their own forked MSVC action for some years and they are keeping maintaining it: https://github.com/TheMrMilchmann/setup-msvc-dev.

I feel a little bit unhappy when I read the git-blame of that interesting "cls" hack: TheMrMilchmann/setup-msvc-dev::src/setup-msvc-dev.ts#L63-L64, which could be from ilammy/msvc-dev-cmd::index.js#L119. IIRC, MIT doesn't force anything about Git history, so I should calm down.

However, we know that something is better than nothing. That's it.

@mk-pmb

This comment was marked as outdated.

@pzhlkj6612
Copy link
Copy Markdown
Contributor

@mk-pmb:

Is this project even still needed?

Someday you may want or need to build something with specific components, for example, an older Windows SDK. You need to call "vcvarsall.bat" and try to figure out how to persist those environment variables, then you see the core of this project.

Package Version
Microsoft.VisualStudio.Component.Windows10SDK 17.14.36510.44
Microsoft.VisualStudio.Component.Windows10SDK.19041 17.14.36809.9
Microsoft.VisualStudio.Component.Windows11SDK.22621 17.14.36510.44
Microsoft.VisualStudio.Component.Windows11SDK.26100 17.14.37011.9

from: https://github.com/actions/runner-images/blob/7dd3415d1d3ad55ae79239951900b4d1268f6f69/images/windows/Windows2022-Readme.md

.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants