IDEMPIERE-6908 Implement iDempiere Extension Management#22
IDEMPIERE-6908 Implement iDempiere Extension Management#22hengsin merged 3 commits intoidempiere:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughAdds a new v14 documentation page describing a centralized Extension Management service: discovery/registration, dependency validation, lifecycle operations (install/uninstall/enable/disable), metadata ingestion, checksum-verified downloads, new persistence tables ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (2)
docs/new-features/v14/extension-management.md (2)
55-55: Use inline code formatting for filter syntax examples.
tag:{filter text}andcategory:{filter text}should be wrapped in backticks for better readability/scannability in docs.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/new-features/v14/extension-management.md` at line 55, Update the docs line that lists filter syntax so the literal examples are shown as inline code: replace the plain text occurrences of tag:{filter text} and category:{filter text} with backtick-wrapped versions (`tag:{filter text}` and `category:{filter text}`) so they render as inline code for readability; ensure both instances (in the "Filter text input" description and any other occurrences nearby) are updated.
24-27: Tighten grammar in user-facing instructions.A few phrases are grammatically incorrect and reduce clarity (e.g., “This include…”, “This is use…”, “Accessed…”, “installed extension”, “include a right side bar”, “entities that managed…”). Please normalize these to standard grammar since this is end-user documentation.
Also applies to: 49-51, 61-61, 72-75
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/new-features/v14/extension-management.md` around lines 24 - 27, The text contains multiple grammatical errors in user-facing descriptions — fix sentence structure and wording for clarity: change “This include” → “This includes”, “This is use” → “This is used to”, “extensions that's bundled” → “extensions that are bundled”, “installed extension” → “installed extensions”, and similar fixes around mentions of AD_Extension, AD_ExtensionEntity and the new form “Extension Management”; scan the whole document (including the other noted sections) and normalize phrases like “Accessed…”, “include a right side bar”, and “entities that managed…” into correct forms so each bullet reads as a complete, grammatical user-facing sentence.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@docs/new-features/v14/extension-management.md`:
- Around line 80-81: The image alt text mismatches the section title: find the
markdown line containing the image tag with alt text "Extension Registry:
Bundled Extension" and update the alt text to "Extension Registry: External
Extension" so it matches the section header; ensure the displayed caption/alt
string in the line starting with  is
replaced accordingly and commit the change.
- Line 25: Fix the two typos in the documentation so UI/process names match
exactly: remove the stray trailing period after the symbol name
`AD_ExtensionEntity` (change "`AD_ExtensionEntity`.:" to "`AD_ExtensionEntity`:"
or similar) and correct the misspelled process name `Enable Extensio` to `Enable
Extension`; ensure both occurrences (the `AD_ExtensionEntity` reference and the
`Enable Extension` label) are spelled exactly as the actual UI/process names so
readers are not confused.
---
Nitpick comments:
In `@docs/new-features/v14/extension-management.md`:
- Line 55: Update the docs line that lists filter syntax so the literal examples
are shown as inline code: replace the plain text occurrences of tag:{filter
text} and category:{filter text} with backtick-wrapped versions (`tag:{filter
text}` and `category:{filter text}`) so they render as inline code for
readability; ensure both instances (in the "Filter text input" description and
any other occurrences nearby) are updated.
- Around line 24-27: The text contains multiple grammatical errors in
user-facing descriptions — fix sentence structure and wording for clarity:
change “This include” → “This includes”, “This is use” → “This is used to”,
“extensions that's bundled” → “extensions that are bundled”, “installed
extension” → “installed extensions”, and similar fixes around mentions of
AD_Extension, AD_ExtensionEntity and the new form “Extension Management”; scan
the whole document (including the other noted sections) and normalize phrases
like “Accessed…”, “include a right side bar”, and “entities that managed…” into
correct forms so each bullet reads as a complete, grammatical user-facing
sentence.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 4c8005d6-d517-44d6-a9c3-b51f01d190ed
⛔ Files ignored due to path filters (5)
static/img/docs/new-features/ExtensionForm_Browse_Available_Extension.pngis excluded by!**/*.pngstatic/img/docs/new-features/ExtensionForm_Browse_Installed_Bundled_Extension.pngis excluded by!**/*.pngstatic/img/docs/new-features/ExtensionForm_Browse_Installed_External_Extension.pngis excluded by!**/*.pngstatic/img/docs/new-features/ExtensionRegistry_Bundled_Extension.pngis excluded by!**/*.pngstatic/img/docs/new-features/ExtensionRegistry_External_Extension.pngis excluded by!**/*.png
📒 Files selected for processing (1)
docs/new-features/v14/extension-management.md
|
@hengsin I think this warning can be removed :::warning Not Yet in Stable Release This feature is not yet part of a stable iDempiere release and may change. ::: This was already merged into v14 and it is a new feature for that version. Also, for the next time, we also agreed that initially all 5 members of the core team do not need to create pull requests, we can all commit directly to make it easier to document. Or create pull requests to see what coderabbit says and merge them ourselves |
2 participants
Summary by CodeRabbit