Skip to content

[Enhancement] allow specifying multiple roles and clusterRoles per namespace #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iwilltry42 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Enhancement] allow specifying multiple roles and clusterRoles per namespace #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/apis/klum.cattle.io/v1alpha1/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ type UserStatus struct {
}

type NamespaceRole struct {
Namespace string `json:"namespace,omitempty"`
ClusterRole string `json:"clusterRole,omitempty"`
Role string `json:"role,omitempty"`
Namespace string `json:"namespace,omitempty"`
ClusterRoles []string `json:"clusterRoles,omitempty"`
Roles []string `json:"roles,omitempty"`
}

// +genclient
Expand Down
58 changes: 31 additions & 27 deletions pkg/controllers/user/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,40 +134,44 @@ func (h *handler) getRoles(user *klum.User) []runtime.Object {

for _, role := range user.Spec.Roles {
if role.Namespace == "" ||
role.Role == "" && role.ClusterRole == "" {
len(role.Roles) == 0 && len(role.ClusterRoles) == 0 {
continue
}

if role.Role != "" {
rb := &rbacv1.RoleBinding{
ObjectMeta: metav1.ObjectMeta{
Name: name(user.Name, role.Namespace, "", role.Role),
Namespace: role.Namespace,
},
Subjects: subjects,
RoleRef: rbacv1.RoleRef{
APIGroup: "rbac.authorization.k8s.io",
Kind: "Role",
Name: role.Role,
},
if len(role.Roles) != 0 {
for _, roleItem := range role.Roles {
rb := &rbacv1.RoleBinding{
ObjectMeta: metav1.ObjectMeta{
Name: name(user.Name, role.Namespace, "", roleItem),
Namespace: role.Namespace,
},
Subjects: subjects,
RoleRef: rbacv1.RoleRef{
APIGroup: "rbac.authorization.k8s.io",
Kind: "Role",
Name: roleItem,
},
}
objs = append(objs, rb)
}
objs = append(objs, rb)
}

if role.ClusterRole != "" {
rb := &rbacv1.RoleBinding{
ObjectMeta: metav1.ObjectMeta{
Name: name(user.Name, role.Namespace, role.ClusterRole, ""),
Namespace: role.Namespace,
},
Subjects: subjects,
RoleRef: rbacv1.RoleRef{
APIGroup: "rbac.authorization.k8s.io",
Kind: "ClusterRole",
Name: role.ClusterRole,
},
if len(role.ClusterRoles) != 0 {
for _, clusterRoleItem := range role.ClusterRoles {
rb := &rbacv1.RoleBinding{
ObjectMeta: metav1.ObjectMeta{
Name: name(user.Name, role.Namespace, clusterRoleItem, ""),
Namespace: role.Namespace,
},
Subjects: subjects,
RoleRef: rbacv1.RoleRef{
APIGroup: "rbac.authorization.k8s.io",
Kind: "ClusterRole",
Name: clusterRoleItem,
},
}
objs = append(objs, rb)
}
objs = append(objs, rb)
}
}

Expand Down