Open
Conversation
mwetter
requested changes
Feb 23, 2026
Contributor
mwetter
left a comment
mwetter
left a comment
There was a problem hiding this comment.
This still has potential rounding issues.
IBPSA/BoundaryConditions/WeatherData/BaseClasses/PartialConvertTime.mo
Outdated
Show resolved
Hide resolved
Contributor
|
@jelgerjansen : can you please provide a review so we have a non-LBL participant approving it. Thanks. |
jelgerjansen
requested changes
Feb 25, 2026
Contributor
jelgerjansen
left a comment
jelgerjansen
left a comment
There was a problem hiding this comment.
@JayHuLBL thanks for looking into this.
I noticed that you still applied some changes (commit 10f3e56) since Michael's approved review (commit 8462d07). Why did you split the initialization event, which is now still using the integer() implementation, from the runtime events, using the numerically more robust implementation?
Additionally, can you also:
- Move the documentation (lines 23-24) to the correct part of the code (
modTimAux > pre(tNext))? - Refer to the IBPSA issue next to the Buildings issue in the review notes (for completeness)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #2088.