Skip to content

fix: 2 improvements across 2 files #3031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tang-vu wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

fix: 2 improvements across 2 files #3031

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7919893
fix: 2 improvements across 2 files
tang-vu Apr 4, 2026
10257d7
fix: 2 improvements across 2 files
tang-vu Apr 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/plugin/isToday/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
export default (o, c, d) => {
const proto = c.prototype
proto.isToday = function () {
const comparisonTemplate = 'YYYY-MM-DD'
const now = d()

return this.format(comparisonTemplate) === now.format(comparisonTemplate)
return this.isSame(d(), 'day')
}
}
2 changes: 1 addition & 1 deletion src/plugin/negativeYear/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ export default (_, c, dayjs) => {
const { date, utc } = cfg
if (typeof date === 'string' && date.charAt(0) === '-') {
const normalData = date.slice(1)
let newDate = dayjs(normalData)
let newDate
if (utc) {
newDate = dayjs.utc(normalData)
} else {
Expand Down