Draft
Conversation
Merged
Contributor
|
thanks @victorapm for continuing this |
lindsayad
reviewed
Jun 26, 2023
| double final_res_norm; | ||
| int interp_type = 100; /* 1-pt Interp */ | ||
| int ns_coarse = 1, ns_down = 0, ns_up = 1; | ||
| int **grid_relax_points = NULL; |
Contributor
There was a problem hiding this comment.
Can't int and HYPRE_Int differ?
Contributor
Author
There was a problem hiding this comment.
They can and I see your point (the APIs expect HYPRE_Int, so it's more correct to use it). But for the examples, the idea is to make them as simple as possible and use standard C types. The team might re-evaluate that...
Contributor
|
@victorapm i stumbled across this today. I think it would be good to get this example in some point |
Contributor
Author
|
Hi Alex, yes I agree, sorry for dropping the ball on this one! I'll put this back on my TODO list |
Contributor
|
No worries! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extended from #932