Open
Conversation
victorapm
approved these changes
Mar 20, 2026
Contributor
victorapm
left a comment
victorapm
left a comment
There was a problem hiding this comment.
Looks great, thanks for all the work!
We still have functions that don't follow the code style in the wiki, e.g., hypre_qsort0 (and alike), hypre_index_of_minimum, hypre_matinv, ...
We could fix it in another PR and add some sort of script to check for these things (happy to volunteer for this work if that makes sense)
waynemitchell
approved these changes
Apr 2, 2026
Contributor
waynemitchell
left a comment
waynemitchell
left a comment
There was a problem hiding this comment.
Thanks for doing all this, Rui Peng!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing the naming of
hypre_GPUKernelFooandhypre_FooDevicefunctions.