Skip to content

Conversation

@pinges
Copy link
Contributor

@pinges pinges commented Dec 19, 2025

PR description

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests
  • hive tests: Engine or other RPCs modified?

mirgee and others added 30 commits December 15, 2025 10:25
…ng with peer task system usage (hyperledger#9178)

* Remove GetBlockFromPeerTask and RetryingGetBlockFromPeersTask, replacing with peer task system usage

Signed-off-by: Matilda Clerke <[email protected]>

* Fix BackwardSyncContextTest

Signed-off-by: Matilda Clerke <[email protected]>

* Use preferred peer first for block retrieval in BlockPropagationManager

Signed-off-by: Matilda Clerke <[email protected]>

* Add new GetHeadersFromPeerTask constructor which doesn't take a block number and use it in SyncStepStep

Signed-off-by: Matilda Clerke <[email protected]>

* Refactor PeerTaskExecutor usage in BlockPropagationManager for better readability

Signed-off-by: Matilda Clerke <[email protected]>

* Fix a != that should have been ==

Signed-off-by: Matilda Clerke <[email protected]>

* Re-add AbstractBlockPropagationManagerTest.shouldRequestBlockFromOtherPeersIfFirstPeerFails and modify to use mock PeerTaskExecutor

Signed-off-by: Matilda Clerke <[email protected]>

* Re-add BackwardSyncContextTest.whenBlockNotFoundInPeers_shouldRemoveBlockFromQueueAndProgressInNextSession

Signed-off-by: Matilda Clerke <[email protected]>

* Fix BlocksSubCommandTest again, but differently

Signed-off-by: Matilda Clerke <[email protected]>

* Remove commented code

Signed-off-by: Matilda Clerke <[email protected]>

---------

Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: [email protected] <[email protected]>
* assert no errors before asserting method calls

Signed-off-by: Sally MacFarlane <[email protected]>

---------

Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: [email protected] <[email protected]>
* exclude icebox'd issues from being marked stale

Signed-off-by: jflo <[email protected]>

* Update .github/workflows/stale-issues.yml

Co-authored-by: Sally MacFarlane <[email protected]>
Signed-off-by: Justin Florentine <[email protected]>

---------

Signed-off-by: jflo <[email protected]>
Signed-off-by: Justin Florentine <[email protected]>
Co-authored-by: Sally MacFarlane <[email protected]>
Signed-off-by: [email protected] <[email protected]>
* add instructions for DCO into DCO.md

Signed-off-by: Sally MacFarlane <[email protected]>

---------

Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: [email protected] <[email protected]>
* make BesuVersionUtils graal-safe

Signed-off-by: garyschulte <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Co-authored-by: Justin Florentine <[email protected]>
Signed-off-by: [email protected] <[email protected]>
…hyperledger#9349)

Attempting to fix flaky behaviour in AbstractBlockProcessorIntegrationTest

Signed-off-by: Simon Dudley <[email protected]>
Signed-off-by: [email protected] <[email protected]>
* tuweni 2.7.2

Signed-off-by: Sally MacFarlane <[email protected]>

---------

Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: [email protected] <[email protected]>
@macfarla macfarla moved this to Open PRs in 26.1.0 Release Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Open PRs

Development

Successfully merging this pull request may close these issues.