Grid layout intracell alignment#269
Conversation
|
Thanks! It looks good to me. Would you rather these three PRs get committed together, or is it fine to do one at a time? |
|
My pleasure. 😃 Not much changes, so I think a squash will be okay so far the new commit message links to this PR 🤔. The breakdown will always be here. |
|
One thing I forgot to mention... I think we should consider making bottom (vertical END) alignment the default for the non-grid layout also. 🤔 |
That sounds good to me! I think I'll start pushing your PRs one at a time when ready, it just means you may have to rebase or resolve conflicts if there are any. |
Okay, we should do that after this PR is merged.
No problem at all. Already figured that would occur. |
- Add `halign` and `valign` fields. - Add `grid_layout_set_align()`.
1ecc6cb to
cec8d72
Compare
|
Rebased ✅ |
Unfortunately, it turns out this won't be good as a default because of the vertical spaces added before each image. |
--gridnow respects--alignwithin each cell.halignandvalignfields toGridLayout.grid_layout_set_align().Resolves #258, while taking #253 (comment) into consideration.