Add bare.css export to snackbar package#512
Open
leonhma wants to merge 1 commit intohperrin:masterfrom
Open
Conversation
Owner
|
Is this needed because you're importing it from JS? I'm a little confused why you would need it to be exported here. |
Author
|
Sorry to take so long to repond. Seems I have missed the notification. Yes. In order to only import the relevant styles and because I didn't have a theme set up, I imported the styles straight from JS. This worked perfectly for all other modules, but not for the snackbar. What I did fixed it. The project kind of found it's way into the abandoned projects bin so it's not a feature I need anymore. Feel free to close this if you don't want to merge it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As it stands bare.css is not exported from the snackbar package. You have to manually change this file after every yarn/yarn add. Please get this released ASAP