Be more specific about what expand-polygon can do#19
Open
bsilver8192 wants to merge 1 commit intohorizon-eda:masterfrom
Open
Be more specific about what expand-polygon can do#19bsilver8192 wants to merge 1 commit intohorizon-eda:masterfrom
bsilver8192 wants to merge 1 commit intohorizon-eda:masterfrom
Conversation
As discussed in horizon-eda/horizon-pool-convention#13, it's complicated and I made some incorrect assumptions after reading this. I think making it clear here will reach anybody who goes looking. The question of how much detail to specify in horizon-pool-convention seems separate to me, because the docs for the parameter program commands should be clear on their own.
Member
|
That command won't create interior holes since polygons are defined by a single contour. Instead, it'll fail. Perhaps we should also point users to clipper and mention that there only must be one resulting polygon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in horizon-eda/horizon-pool-convention#13, it's complicated and I made some incorrect assumptions after reading this. I think making it clear here will reach anybody who goes looking.
The question of how much detail to specify in horizon-pool-convention seems separate to me, because the docs for the parameter program commands should be clear on their own.