refactor(client): make properties readonly and adjust modifiers#4763
Closed
BelovedYaoo wants to merge 1 commit intohonojs:mainfrom
Closed
refactor(client): make properties readonly and adjust modifiers#4763BelovedYaoo wants to merge 1 commit intohonojs:mainfrom
BelovedYaoo wants to merge 1 commit intohonojs:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4763 +/- ##
=======================================
Coverage 91.48% 91.48%
=======================================
Files 177 177
Lines 11551 11551
Branches 3353 3354 +1
=======================================
Hits 10567 10567
Misses 983 983
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yusukebe
reviewed
Feb 24, 2026
| @@ -31,9 +31,9 @@ const createProxy = (callback: Callback, path: string[]) => { | |||
| } | |||
|
|
|||
| class ClientRequestImpl { | |||
Member
There was a problem hiding this comment.
ClientRequestImpl is only used in internal. This refactor is not necessary right now.
| * Additional `message` that will be logged AND returned to client | ||
| */ | ||
| public detail?: any | ||
| detail?: any |
Member
There was a problem hiding this comment.
This file is ported from another package
The author intended marking as public. And it's not a problem making them public. This refactoring is not necessary.
Member
|
I think these refactorings are not necessary. Closing. |
Author
|
ok,sorry for making two unnecessary changes. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the codemark properties as readonly and adjust access modifiers in client classes to improve immutability and encapsulation :)