perf(aws-lambda): optimize header parsing to reduce micro-allocations#4762
Open
fcarvajalbrown wants to merge 1 commit intohonojs:mainfrom
Open
perf(aws-lambda): optimize header parsing to reduce micro-allocations#4762fcarvajalbrown wants to merge 1 commit intohonojs:mainfrom
fcarvajalbrown wants to merge 1 commit intohonojs:mainfrom
Conversation
Member
|
Hi @fcarvajalbrown For future pull requests, please include a description following this template: Regarding this pull request, I believe it is a reasonable small improvement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR optimizes the getHeaders method in the AWS Lambda adapter. By switching from Object.entries() to a for...in loop with a safety check, we avoid the overhead of creating intermediate arrays for every request.
In high-throughput serverless environments, reducing these "micro-allocations" significantly lowers Garbage Collection (GC) pressure and minimizes latency jitter.
Performance Details
benchmark avg (min … max) p75 / p99
Current (Object.entries) 1.26 µs/iter 1.20 µs / 2.30 µs
Optimized (for...in) 851.85 ns/iter 860.13 ns / 954.57 ns
Summary:
Optimized (for...in) is 1.48x faster than Current (Object.entries)
Testing