Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes CarPlay entity icon rendering by ensuring HAEntity.getIcon() uses the resolved Material Design Icon (custom attribute icon or domain-based fallback) instead of always returning the default bookmark icon, and adds regression tests for the expected fallback behavior.
Changes:
- Update
HAEntity.getIcon()to usegetMDI()as the base icon source. - Add unit tests verifying CarPlay icon selection for (a) no custom icon and (b) custom
attributes.iconpresent.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Tests/Shared/HAEntityCarPlay.test.swift | Adds regression tests covering CarPlay icon fallback and custom icon preservation. |
| Sources/Shared/HAEntity+CarPlay.swift | Fixes icon selection by using getMDI() output rather than an unconditional default icon. |
Co-authored-by: Copilot <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4464 +/- ##
=======================================
Coverage ? 42.51%
=======================================
Files ? 267
Lines ? 15650
Branches ? 0
=======================================
Hits ? 6654
Misses ? 8996
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes