Improve labs label spacing and rename it#4462
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR renames the existing “Beta” label component to “Labs” and adjusts the internal padding to improve the badge’s visual spacing, then updates call sites to use the new names.
Changes:
- Renamed
BetaLabel→LabsLabeland tweaked label padding for improved spacing. - Renamed
MTLSBetaLabel→MTLSLabsLabeland updated usages in Settings and onboarding flows. - Updated the Xcode project file references to reflect the renamed Swift files.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Sources/Shared/DesignSystem/Components/LabsLabel.swift | Renames the public badge view type and adjusts internal padding; updates previews. |
| Sources/App/Settings/Settings/SettingsView.swift | Replaces BetaLabel() with LabsLabel() in the Settings list row. |
| Sources/App/Settings/Connection/ConnectionSettingsView.swift | Updates the mTLS badge view name used in the client certificate section header. |
| Sources/App/Onboarding/Views/MTLSLabsLabel.swift | Renames the mTLS wrapper badge view and swaps to LabsLabel. |
| Sources/App/Onboarding/Views/ClientCertificateOnboardingView.swift | Updates onboarding UI to use MTLSLabsLabel(). |
| HomeAssistant.xcodeproj/project.pbxproj | Renames file references/build entries for the updated Swift filenames. |
Comments suppressed due to low confidence (3)
Sources/Shared/DesignSystem/Components/LabsLabel.swift:3
LabsLabelis a new public type replacingBetaLabel. Since this is in the Shared module, the rename is a source-breaking API change for any downstream targets that may still referenceBetaLabel. Consider keeping a deprecated compatibility alias (e.g., atypealiasor wrapper) so existing code continues to compile while migrating.
Sources/Shared/DesignSystem/Components/LabsLabel.swift:89- The preview’s sample
infotext still refers to a “beta label”, which is now inconsistent with the renamedLabsLabel. Updating the wording will avoid confusion when using previews as reference/documentation.
Sources/App/Onboarding/Views/MTLSLabsLabel.swift:7 MTLSLabsLabelnow shows a Labs badge but still usesL10n.Mtls.Beta.info, whose localized text describes this as a “beta feature”. This creates a user-facing terminology mismatch; consider adding/updating a Labs-specific localization string (or updating the existing text) to match the new “Labs” label.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4462 +/- ##
=======================================
Coverage ? 42.52%
=======================================
Files ? 267
Lines ? 15651
Branches ? 0
=======================================
Hits ? 6656
Misses ? 8995
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes