Skip to content

Improve labs label spacing and rename it#4462

Merged
bgoncal merged 1 commit intomainfrom
beta-label-spacing
Mar 31, 2026
Merged

Improve labs label spacing and rename it#4462
bgoncal merged 1 commit intomainfrom
beta-label-spacing

Conversation

@bgoncal
Copy link
Copy Markdown
Member

@bgoncal bgoncal commented Mar 31, 2026

Summary

Screenshots

CleanShot 2026-03-31 at 10 36 48@2x

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

@bgoncal bgoncal self-assigned this Mar 31, 2026
@bgoncal bgoncal added the mtls label Mar 31, 2026
Copilot AI review requested due to automatic review settings March 31, 2026 08:37
@bgoncal bgoncal added the kiosk label Mar 31, 2026
@bgoncal bgoncal enabled auto-merge (squash) March 31, 2026 08:38
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR renames the existing “Beta” label component to “Labs” and adjusts the internal padding to improve the badge’s visual spacing, then updates call sites to use the new names.

Changes:

  • Renamed BetaLabelLabsLabel and tweaked label padding for improved spacing.
  • Renamed MTLSBetaLabelMTLSLabsLabel and updated usages in Settings and onboarding flows.
  • Updated the Xcode project file references to reflect the renamed Swift files.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Sources/Shared/DesignSystem/Components/LabsLabel.swift Renames the public badge view type and adjusts internal padding; updates previews.
Sources/App/Settings/Settings/SettingsView.swift Replaces BetaLabel() with LabsLabel() in the Settings list row.
Sources/App/Settings/Connection/ConnectionSettingsView.swift Updates the mTLS badge view name used in the client certificate section header.
Sources/App/Onboarding/Views/MTLSLabsLabel.swift Renames the mTLS wrapper badge view and swaps to LabsLabel.
Sources/App/Onboarding/Views/ClientCertificateOnboardingView.swift Updates onboarding UI to use MTLSLabsLabel().
HomeAssistant.xcodeproj/project.pbxproj Renames file references/build entries for the updated Swift filenames.
Comments suppressed due to low confidence (3)

Sources/Shared/DesignSystem/Components/LabsLabel.swift:3

  • LabsLabel is a new public type replacing BetaLabel. Since this is in the Shared module, the rename is a source-breaking API change for any downstream targets that may still reference BetaLabel. Consider keeping a deprecated compatibility alias (e.g., a typealias or wrapper) so existing code continues to compile while migrating.
    Sources/Shared/DesignSystem/Components/LabsLabel.swift:89
  • The preview’s sample info text still refers to a “beta label”, which is now inconsistent with the renamed LabsLabel. Updating the wording will avoid confusion when using previews as reference/documentation.
    Sources/App/Onboarding/Views/MTLSLabsLabel.swift:7
  • MTLSLabsLabel now shows a Labs badge but still uses L10n.Mtls.Beta.info, whose localized text describes this as a “beta feature”. This creates a user-facing terminology mismatch; consider adding/updating a Labs-specific localization string (or updating the existing text) to match the new “Labs” label.

@bgoncal bgoncal merged commit e513027 into main Mar 31, 2026
16 checks passed
@bgoncal bgoncal deleted the beta-label-spacing branch March 31, 2026 08:58
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@2d48995). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ces/Shared/DesignSystem/Components/LabsLabel.swift 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4462   +/-   ##
=======================================
  Coverage        ?   42.52%           
=======================================
  Files           ?      267           
  Lines           ?    15651           
  Branches        ?        0           
=======================================
  Hits            ?     6656           
  Misses          ?     8995           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants