PPO2: Call total_episode_reward_logger before incrementing num_timesteps#556
Open
balintkozma wants to merge 1 commit intohill-a:masterfrom
Open
PPO2: Call total_episode_reward_logger before incrementing num_timesteps#556balintkozma wants to merge 1 commit intohill-a:masterfrom
balintkozma wants to merge 1 commit intohill-a:masterfrom
Conversation
Collaborator
|
Hello, Please fill in the PR template completely. |
d674c80 to
b053747
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In ppo2.py
total_episode_reward_loggershould be called before incrementingnum_timesteps. See explanation in #143.Motivation and Context
It improves the reported episode reward logging issue, and a PR was asked.
Types of changes
Checklist: