This repository was archived by the owner on Mar 16, 2024. It is now read-only.
[wip] always close the HTTP response body#98
Open
freedge wants to merge 1 commit intoheroku:masterfrom
Open
Conversation
when the auth service return an HTTP error code we make sure to close the HTTP response body to avoid a socket leak.
Author
|
this project might be abandoned. I think there might be some other leaks of this kind. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when the auth service return an HTTP error code
we make sure to close the HTTP response body
to avoid a socket leak.
wip because I did not test that extensively