v3_CASL-1159_naksha-cli-generating-storage-config-validation #488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czyz-bartosz
force-pushed
the
v3_CASL-1159_naksha-cli-generating-storage-config-validation
branch
from
4ce2c7c to
2151776
Compare
Amaneusz
reviewed
Sep 1, 2025
| import java.util.List; | ||
|
|
||
| @FunctionalInterface | ||
| public interface Validator<T, S> { |
Contributor
There was a problem hiding this comment.
what's T and S? some doc would be nice
|
|
||
| @Override | ||
| @NotNull | ||
| protected PlatformMap createData() { |
Contributor
There was a problem hiding this comment.
For initial data population - use onCreation rather than createData
| ); | ||
| } | ||
| validateFields(map); | ||
| super.bind(data, symbol); |
Contributor
There was a problem hiding this comment.
I don't think bind is the best place to perform validation. This adds on behavior that this method was not responsible for.
Contributor
There was a problem hiding this comment.
Perhaps it would be best to keep Proxy-related logic unaware of validation and vice-versa. So that we don't rely on Proxy lifecycle methods.
One potential solution is client-side validation where we pass the validated object as parameter
Signed-off-by: Bartosz Czyż <[email protected]> # Conflicts: # here-naksha-cli/src/jvmMain/java/com/here/naksha/cli/copy/CopyCommand.java # here-naksha-cli/src/jvmMain/java/com/here/naksha/cli/copy/service/CopyService.java # here-naksha-cli/src/jvmTest/java/com/here/naksha/cli/copy/CopyCliTest.java
czyz-bartosz
force-pushed
the
v3_CASL-1159_naksha-cli-generating-storage-config-validation
branch
from
2151776 to
951145d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.