Skip upload for release step #214
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Igor Nikolenko <ihor.nikolenko@paramount.com>
Signed-off-by: Igor Nikolenko <ihor.nikolenko@paramount.com>
Author
|
Hi, |
Signed-off-by: Igor Nikolenko <ihor.nikolenko@paramount.com>
Signed-off-by: Igor Nikolenko <ihor.nikolenko@paramount.com>
Signed-off-by: Igor Nikolenko <ihor.nikolenko@paramount.com>
cpanato
requested changes
Jan 20, 2025
|
|
||
| for chart in "${changed_charts[@]}"; do | ||
| if [[ -d "$chart" ]]; then | ||
| helm repo add bitnami https://charts.bitnami.com/bitnami |
|
Any chance we could move forward with this? I can create a separate PR, it looks like a bug, upload shouldn't be required with OCI at all. |
|
Please, could this not-too-complex PR be reviewed and merged? |
Member
|
yes you can create another PR |
What for, What's wrong with this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve the issue with upload from release_charts step when --skip-upload passed.
Upload from release_charts creates an issue in case you wish to use cr tool for packaging only (for example when you use OCI repository).
Using this fix for some month without any issue.