Fix problem with double search#275
Merged
heiglandreas merged 1 commit intomasterfrom Apr 15, 2025
Merged
Conversation
Due to the change in authentication and authorization we need to search the use4r a second time during the authorization phase. Should the user have been identified with a different property than the one used for the WordPress username, that would fail as we passed in only the WP_User that didn't have the original parameter anymore. I could instead also have created a filter myself based on the WP_User objects username and the username attribute, now that i think about it. This seemed more straight forward...
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the change in authentication and authorization we need to search the use4r a second time during the authorization phase. Should the user have been identified with a different property than the one used for the WordPress username, that would fail as we passed in only the WP_User that didn't have the original parameter anymore.
I could instead also have created a filter myself based on the WP_User objects username and the username attribute, now that i think about it. This seemed more straight forward...
Fixes #274