feat(SourceT): add fromConsumableActionStep that creates a StepT from…#1533
Open
giulioforesto wants to merge 1 commit intohaskell-servant:masterfrom
Open
Conversation
alpmestan
requested changes
Feb 16, 2022
Contributor
alpmestan
left a comment
alpmestan
left a comment
There was a problem hiding this comment.
Thanks for the patch!
LGTM, just a little bit of nitpicking.
giulioforesto
force-pushed
the
generalize-fromActionStep-to-consumable
branch
4 times, most recently
from
0725a12 to
bf28f64
Compare
alpmestan
approved these changes
Feb 18, 2022
Contributor
alpmestan
left a comment
alpmestan
left a comment
There was a problem hiding this comment.
This seems ready to land, modulo the hardest part: the name of your function :-)
I think I'm warming up to unfoldStep.
Author
Haha go for |
… an action that consumes some data
giulioforesto
force-pushed
the
generalize-fromActionStep-to-consumable
branch
from
bf28f64 to
2947532
Compare
Author
|
There you go, thanks for the review |
alpmestan
approved these changes
Feb 18, 2022
Contributor
|
@giulioforesto The doctest isn't passing for me. Was this only meant as a hint/suggestion, or was it supposed to be actually be an executable doctest? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… an action that consumes some data
Closes #1448