Rewrite action with github-script#8
Open
brandonchinn178 wants to merge 1 commit intohaskell-actions:mainfrom
Open
Rewrite action with github-script#8brandonchinn178 wants to merge 1 commit intohaskell-actions:mainfrom
brandonchinn178 wants to merge 1 commit intohaskell-actions:mainfrom
Conversation
fb91ddd to
2b42ba7
Compare
953ae04 to
1b9c8e1
Compare
1b9c8e1 to
ff50cc1
Compare
Member
Author
|
@AlexeyRaga Is this package still maintained? If not, I'd be happy to take over. |
|
What are the functional advantages of this PR @brandonchinn178 ? How does it behave better than the bash-based action? |
Member
Author
|
Three concrete functional advantages from just a quick skim of the bash code:
Sure, maybe these arent terrible issues, and maybe the script is small enough to be easy to debug or whatever. But bash has so many small edge cases that can bite you later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Javascript is much better than bash, with proper error mechanisms, better variables, better for-loops, etc. This also lets us use all the utilities normal GitHub actions can use, via actions/github-script, taking advantage of the whole ecosystem.
Also changed input
publishtocandidatebecause it feels weird to say "runhackage-publishbut don't publish".Tested here: https://github.com/fourmolu/fourmolu/actions/runs/4624388970/jobs/8203029673