refactor: Remove TimestampProvider and use EvmAccessors.getMsgSender()#957
Merged
mamoralesiob merged 3 commits intorefactor/BBND-1458-59-60-lib-diamond-migrationfrom Apr 20, 2026
Conversation
Signed-off-by: mamoralesiob <[email protected]>
Signed-off-by: mamoralesiob <[email protected]>
mamoralesiob
changed the title
mamoralesiob
changed the title
After TimestampProvider deletion, production facets call TimeTravelStorageWrapper.getBlockTimestamp() directly (static library call). The _getBlockTimestamp/_getBlockNumber overrides in each *FacetTimeTravel variant were no-ops that just called the parent, and are never reached via virtual dispatch. Remove them and update TimeTravelProvider's stale NatDoc. The TimeTravel facet variants remain as empty marker contracts pending the broader "best time-travel pattern" discussion. Signed-off-by: Miguel_LZPF <[email protected]>
MiguelLZPF
approved these changes
Apr 20, 2026
mamoralesiob
merged commit a9c2fde
into
refactor/BBND-1458-59-60-lib-diamond-migration
14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TimestampProviderwas removed andmsg.senderwas substituted byEvmAccessors.getMsgSender()Type of change
Testing
Node version:
Checklist