Fix bugs in methodExtraction/HttpRequest.kt and update Kotlin version#71
Closed
Fix bugs in methodExtraction/HttpRequest.kt and update Kotlin version#71
Conversation
Copilot
AI
changed the title
[WIP] Resolve conflicts in PR #66
Fix bugs in methodExtraction/HttpRequest.kt and update Kotlin version
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves conflicts in PR #66 by addressing two bugs in the
HttpRequest.ktfile and updating the Kotlin JVM plugin version.Changes
Fixed a bug in
matchMethod()function:this.bodyinstead ofthis.methodwhen comparing HTTP methodsFixed a bug in
matchBody()function:"${this.method} not equal to ${anotherRequest.method}"to"${this.body} not equal to ${anotherRequest.body}"Updated Kotlin JVM plugin version:
2.1.20to2.1.21in build.gradle to match PR Bump org.jetbrains.kotlin.jvm from 2.1.20 to 2.1.21 #66All tests pass with these changes, and the code now correctly compares HTTP request components.
Fixes #70.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.