Skip to content

Comments

feat: add initial support for QF_FP#31

Draft
abdoo8080 wants to merge 1 commit intohargoniX:mainfrom
abdoo8080:fp
Draft

feat: add initial support for QF_FP#31
abdoo8080 wants to merge 1 commit intohargoniX:mainfrom
abdoo8080:fp

Conversation

@abdoo8080
Copy link
Collaborator

No description provided.

@abdoo8080 abdoo8080 changed the title chore: add initial support for FP chore: add initial support for QF_FP Dec 10, 2025
@hargoniX
Copy link
Owner

hargoniX commented Dec 16, 2025

This looks reasonable to me in principle, though I wonder about one thing: iirc in the SMT-LIB benchmarking we noticed that a significant part of the overhead was due to loading olean files from the disk right? With this PR the number of file system accesses is going to increase quite a lot right?

Apart from that I'd love to get the changes that you made to make Leanwuzla build on the current version again in though. I would ideally like to move the whole thing to the module system to reduce setup times a bit.

@hargoniX
Copy link
Owner

A quick test on one of the SMT-LIB files I used to base benchmarks of in lean core shows that they are currently at 0.76s on Leanwuzla master, 0.87s with your changes and 0.67s with your changes - Fp. Would be kind of a shame to throw away those 10% of improvement 😅

@abdoo8080
Copy link
Collaborator Author

Sure! I can break the PR into two!

@abdoo8080 abdoo8080 changed the title chore: add initial support for QF_FP feat: add initial support for QF_FP Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants