Add missing tests: NetworkManager.spec.ts (#2176)#3260
Merged
Conversation
Add three error handling tests from upstream NetworkManager.test.ts: - should not throw on target close error - should not throw on unsupported errors - should throw on non-TargetClose errors Also fix NetworkManager Apply* methods to match upstream error handling by adding CanIgnoreError catch blocks to each method. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NetworkManager.test.ts:should not throw on target close error,should not throw on unsupported errors, andshould throw on non-TargetClose errorsNetworkManager.Apply*methods to addCanIgnoreErrorcatch blocks matching upstream behavior, so errors likeTargetClosedExceptionand "Not supported" are silently ignoredTest plan
Closes #2176
🤖 Generated with Claude Code