Add missing tests: page.spec.ts Page.select (#2172)#3259
Merged
Conversation
…lass (#2172) Port upstream test "should work when re-defining top-level Event class" from the Page.select describe block in page.spec.ts. This test verifies that Page.SelectAsync works correctly even when the top-level Event class is redefined (set to undefined) on the page. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Page.selectdescribe block inpage.spec.tsPage.SelectAsyncworks correctly even when the top-levelEventclass is set toundefinedon the page (see upstream issue Puppeteer page.select got error: Cannot read property 'indexOf' of undefined puppeteer/puppeteer#3327)Closes #2172
Test plan
ShouldWorkWhenReDefiningTopLevelEventClasspasses with Chrome/CDP🤖 Generated with Claude Code