Change nginx configs to also listen for ipv6 requests#264
Open
flo-at wants to merge 1 commit intohaiwen:masterfrom
Open
Change nginx configs to also listen for ipv6 requests#264flo-at wants to merge 1 commit intohaiwen:masterfrom
flo-at wants to merge 1 commit intohaiwen:masterfrom
Conversation
|
It's crazy there is no response of this PR at all. I guess they only do things when they get support requests from paying customers. |
Author
|
@robclancy This is also true for other (bigger) problems in Seafile. If you are still using it, you might want to consider switching to something else. There are concerns that it's not safe anymore to expose Seafile on a public host. Also the repository is a hot mess. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes to the nginx config files/templates make IPv6 work.
For IPv6-only setups this solves a more complex problem where you need to initially start the container with Let’s Encrypt disabled because it cannot get the chellenge file due to this missing listen directive in the nginx config. Then you would need to manually change the nginx config which is only generated at the initial start-up and therefore does not include the TLS config.