Add Accomplishment model and API endpoints for Feature #48 #530

drakeredwind01 · 2025-09-03T19:01:30Z

Fixes #48

What changes did you make?

Added Accomplishment model with proper fields and relationships
Added API endpoints with serializers, views, and URL routing
Added Django admin registration for the new model
Implemented comprehensive test coverage utilizing test fixtures
Made database migration

Why did you make the changes (we will use this info to test)?

To implement the Accomplishment model as specified in issue Create Table: Accomplishment #48
To provide REST API endpoints for managing Accomplishment records
To ensure proper integration with the existing codebase
To maintain code quality with comprehensive test coverage

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

N/A (No visual changes, backend implementation only)

Visuals after changes are applied

N/A (No visual changes, backend implementation only)

Files Modified/Added:

File	Changes
app/core/models.py	Added Accomplishment model
`app/core/api/serializers.py`	Added AccomplishmentSerializer
`app/core/api/views.py`	Added AccomplishmentViewSet
`app/core/api/urls.py`	Added accomplishments URL routing
`app/core/admin.py`	Added admin registration
`app/core/tests/test_api.py`	Added test function
app/core/tests/conftest.py	Added Accomplishment fixture
`app/core/migrations/0039_accomplishment.py`	Created migration

Reference:

Original issue: Create Table: Accomplishment #48
Previous attempt: https://github.com/hackforla/peopledepot/pull/476/files

dmartin4820

The only thing still missing that I can tell is a test for the new accomplishment model.

Attaching a link to the tutorial I normally follow as a checklist of things to do.

dmartin4820

re-requesting. hit the request review accidentally

dmartin4820

Major comments that need to be resolved before anything else.

.gitignore

app/core/migrations/max_migration.txt

app/core/models.py

drakeredwind01 · 2025-11-24T06:28:15Z

addressed all issues

'app/core/models.py' - Enhanced model with full documentation
'app/core/models.py' - Restored created_at and updated_at to AbstractBaseModel
'app/core/api/serializers.py' - Added updated_at field
'app/core/migrations/0043_accomplishment.py' - New migration (correct sequence)
'app/core/migrations/max_migration.txt' - Updated to 0043
'app/core/migrations/0039_accomplishment.py' - Will be deleted
'TODO.md' - Will be deleted

I trust everything is finally in order. i hope.

fyliu

Thanks for the PR!

I squashed the commits and combined the migrations. I had to do that in order to rebase it to hackforla/main.

I found some small issues in the comments that you should fix. Please message me or reply to the comments if you need anything.

fyliu · 2026-01-17T00:02:52Z

.gitignore

 *.pyc

 .vscode
+TODO.md


This looks you have a local file to ignore. It shouldn't be committed to the project though.

You can move this line to .git/info/exclude so it applies only to your local repo.

fyliu · 2026-01-17T04:34:45Z

app/core/models.py

 class AbstractBaseModel(models.Model):
    """
-    Base abstract model, that has `uuid` instead of `id` and included `created_at`, `updated_at` fields.
+    Base abstract model, that has `uuid` instead of `id` fields.


These lines shouldn't be changed since it's not part of the issue.

fyliu · 2026-01-17T05:37:40Z

app/core/models.py

+        indexes = [
+            models.Index(fields=["project"], name="core_accomp_project_idx"),
+            models.Index(fields=["accomplished_on"], name="core_accomp_date_idx"),
+        ]


It's not necessary to add these indexes. Django already adds some default ones that overlap these.

fyliu

Thanks for the PR!

I found a few issues that you should fix. Thanks!

Also, you should add a test in test_models.py . It's not very interesting, but it's good to develop the habit of writing tests.

fyliu · 2026-01-25T17:28:52Z

I pushed commits for autoformat and new migration for the latest change.

I'm not sure why Github didn't add the formatting commit automatically like it should've.

fyliu · 2026-01-25T17:34:05Z

I squashed the PR's commits into one and combined the migrations. The branch is still behind main so I'll need to rebase it.

fyliu · 2026-01-25T17:50:16Z

I did the rebase and resolved trivial conflicts.

The requested items were all completed and tests are passing.

fyliu

Looks great. Thanks!

github-project-automation bot added this to P: PD: Project Board Sep 3, 2025

drakeredwind01 mentioned this pull request Sep 3, 2025

Create Table: Accomplishment #48

Closed

18 tasks

fyliu moved this to PR Needs review (automated column, do not place items here manually) in P: PD: Project Board Sep 3, 2025

fyliu assigned drakeredwind01 Sep 5, 2025

fyliu requested a review from dmartin4820 September 5, 2025 01:12

fyliu mentioned this pull request Sep 5, 2025

Feature/#48 drakeredwind01 accomplishment #476

Closed

dmartin4820 requested changes Sep 8, 2025

View reviewed changes

github-project-automation bot moved this from PR Needs review (automated column, do not place items here manually) to PR changes requested in P: PD: Project Board Sep 8, 2025

dmartin4820 self-requested a review September 16, 2025 01:19

dmartin4820 requested changes Sep 16, 2025

View reviewed changes

fyliu mentioned this pull request Oct 9, 2025

PeopleDepot Team Meeting Agenda 2025 #461

Closed

fyliu force-pushed the main branch from a3ba1f3 to 1c6e0db Compare October 11, 2025 06:04

drakeredwind01 force-pushed the Feature/48-drakeredwind01-accomplishment branch from ab51173 to 1637d67 Compare October 24, 2025 00:50

dmartin4820 requested changes Oct 30, 2025

View reviewed changes

.gitignore Outdated Show resolved Hide resolved

app/core/migrations/max_migration.txt Outdated Show resolved Hide resolved

app/core/models.py Show resolved Hide resolved

fyliu mentioned this pull request Nov 3, 2025

Feature/#48 drakeredwind01 accomplishment #544

Closed

drakeredwind01 force-pushed the Feature/48-drakeredwind01-accomplishment branch from 6431410 to efad993 Compare November 21, 2025 02:42

dmartin4820 self-requested a review November 24, 2025 01:58

dmartin4820 approved these changes Nov 24, 2025

View reviewed changes

dmartin4820 requested a review from fyliu November 24, 2025 02:09

fyliu force-pushed the Feature/48-drakeredwind01-accomplishment branch 3 times, most recently from 96f4943 to c32d8ed Compare January 17, 2026 05:38

fyliu requested changes Jan 17, 2026

View reviewed changes

fyliu previously requested changes Jan 23, 2026

View reviewed changes

fyliu force-pushed the Feature/48-drakeredwind01-accomplishment branch from 16f3d99 to 061e6a2 Compare January 25, 2026 17:32

Add Accomplishment model and API endpoints for Feature #48

58af063

fyliu force-pushed the Feature/48-drakeredwind01-accomplishment branch from 061e6a2 to 58af063 Compare January 25, 2026 17:49

fyliu approved these changes Jan 25, 2026

View reviewed changes

github-project-automation bot moved this from PR changes requested to 🔖PR ready to merge in P: PD: Project Board Jan 25, 2026

fyliu merged commit ef2e97b into main Jan 25, 2026
2 checks passed

fyliu deleted the Feature/48-drakeredwind01-accomplishment branch January 25, 2026 17:53

github-project-automation bot moved this from 🔖PR ready to merge to ✅Done in P: PD: Project Board Jan 25, 2026

               *.pyc
               .vscode
+              TODO.md

Uh oh!

Add Accomplishment model and API endpoints for Feature #48 #530

Add Accomplishment model and API endpoints for Feature #48 #530

Uh oh!

Conversation

drakeredwind01 commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes did you make?

Why did you make the changes (we will use this info to test)?

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Files Modified/Added:

Reference:

Uh oh!

dmartin4820 left a comment

Choose a reason for hiding this comment

Uh oh!

dmartin4820 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dmartin4820 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

drakeredwind01 commented Nov 24, 2025

Uh oh!

fyliu left a comment

Choose a reason for hiding this comment

Uh oh!

fyliu Jan 17, 2026

Choose a reason for hiding this comment

Uh oh!

fyliu Jan 17, 2026

Choose a reason for hiding this comment

Uh oh!

fyliu Jan 17, 2026

Choose a reason for hiding this comment

Uh oh!

fyliu left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fyliu commented Jan 25, 2026

Uh oh!

fyliu commented Jan 25, 2026

Uh oh!

fyliu commented Jan 25, 2026

Uh oh!

fyliu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

drakeredwind01 commented Sep 3, 2025 •

edited

Loading

dmartin4820 left a comment •

edited

Loading

fyliu left a comment •

edited

Loading