[Fix] Fixing appearance of noscript warning#13
Open
nikita-kun wants to merge 1 commit intogwern:masterfrom
Open
[Fix] Fixing appearance of noscript warning#13nikita-kun wants to merge 1 commit intogwern:masterfrom
nikita-kun wants to merge 1 commit intogwern:masterfrom
Conversation
Text color is changed from grey-on-white-background to the colors of the admonition CSS style. Fixed broken appearance of links. The floating block size and location is adjusted to avoid wasting space. Another revision is needed if the warning is to be made dismissable without the use of JS.
Owner
|
We agree that the existing noscript is not very good, but Achmiz wants to take a different approach and is still working on the refactoring. |
Owner
|
Historical note: the noscript was tweaked in 66bd82f in preparation for a fix, but it never got finished, so right now in Firefox the JS-blocked appearance is broken. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Text color is changed from grey-on-white-background to the colors of the admonition CSS style. Fixed broken appearance of links. The floating block size and location are adjusted to avoid wasting space. Another revision is needed if the warning is to be made dismissable without the use of JS.
Before
After