Use time-domain waveforms for bank generation #5227
+21
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kkacanja
reviewed
Nov 20, 2025
| parser.add_argument('--minimal-match', default=0.97, type=float) | ||
| parser.add_argument('--buffer-length', default=2, type=float, | ||
| help='size of waveform buffer in seconds') | ||
| parser.add_argument('--use-td-waveform', action='store_true', |
Contributor
There was a problem hiding this comment.
I think it would be better to remove the option and have the code handle the waveform generation internally. So if the approximant is TD use the time domain waveform, if the approximant is in fd_approximants use the frequency domain handling.
Contributor
Author
There was a problem hiding this comment.
@kkacanja The pycbc_brute_bank code already handles this automatically. The --use-td-waveform option would simply force the code to use time-domain waveforms exclusively, which can be useful for faster bank generation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A support for generating template banks using time-domain waveforms
This feature extends pycbc_brute_bank to allow users to generate template banks using time-domain (TD) waveform models.
This change affects: the offline search
This change changes: documentation, scientific output
Motivation
The main motivation for this feature is that several waveform families either lack faster frequency-domain implementations or are substantially more accurate when evaluated in the time domain. Because the pycbc_brute_bank code computes matches in the frequency domain, TD waveforms must be converted before overlaps can be calculated. Using TD waveforms requires an additional step where the generated time-series waveform is converted to the frequency domain using the get_fd_waveform_from_td function in waveform.py, before the match calculation is done. This step conversion step introduces additional computational cost, and in some cases (eg. SEOBNRv5HM) may dominate the overall runtime of the bank generation process.
This PR implements the TD-to-FD conversion internally using a straightforward FFT-based calculation.