Open
Conversation
jamesmockett
force-pushed
the
jm/wire-up-live-blog
branch
from
a324194 to
aa489b3
Compare
jamesmockett
force-pushed
the
jm/wire-up-live-blog
branch
from
e835813 to
d0727f5
Compare
jamesmockett
changed the base branch from
main
to
jm/match-stats-summary-schema
jamesmockett
changed the base branch from
jm/match-stats-summary-schema
to
main
jamesmockett
force-pushed
the
jm/wire-up-live-blog
branch
from
d0727f5 to
0dba314
Compare
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
jamesmockett
force-pushed
the
jm/wire-up-live-blog
branch
3 times, most recently
from
cd5fcb8 to
e16a002
Compare
These is to ensure the component appears to flow over any ads when it is placed in the left column of the live blog layout on desktop
Match nav is part of the new match header
jamesmockett
force-pushed
the
jm/wire-up-live-blog
branch
from
a4e8f9b to
d000014
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Updates
LiveLayoutto use new football match header and mini match stats components on football live blogs. These are only shown if the user is in the variant group of thewebex-football-redesigntest, otherwise the existing header and stats are shown as before.To enable this, the
FootballMiniMatchStatscomponent has been updated to support fetching and polling of match stats data on the client as this is not available as part of the data model when the page is initially rendered on the server.Screenshots