Draft
Conversation
tomrf1
force-pushed
the
tf-feast-thrasher-tweaks
branch
from
ca62cc7 to
1cf1d22
Compare
tomrf1
force-pushed
the
tf-feast-thrasher-tweaks
branch
from
b2bc41e to
878d4c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new FeastThrasher component will be used for both web and apps fronts.
On apps only we want to adjust the style slightly. This PR adds left/right margin and rounded corners to the container.
While testing this I discovered an issue on the iOS app only where it was scrolling within the webview. The fix was not obvious. We have to set
overflow: hiddenon the body to prevent this.Interestingly, removing
<!doctype html>solved the scrolling issue (it enables quirks mode which changes how height is determined), but this then messes up the layout of the component, e.g. the image.iOS